Re: [COMMITTERS] pgsql: Implement table partitioning.

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Stephen Frost <sfrost(at)snowman(dot)net>
Cc: "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [COMMITTERS] pgsql: Implement table partitioning.
Date: 2016-12-08 19:06:58
Message-ID: CA+Tgmob8fYhw_kO+T=GUCSvXTZZOx3dc2pxChRYwvqu5JrCvDQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

On Thu, Dec 8, 2016 at 1:49 PM, Stephen Frost <sfrost(at)snowman(dot)net> wrote:
> * Robert Haas (rhaas(at)postgresql(dot)org) wrote:
>> Implement table partitioning.
>
> My compiler apparently doesn't care for this:
>
> .../src/backend/catalog/partition.c: In function ‘partition_rbound_cmp’:
> .../src/backend/catalog/partition.c:1787:13: warning: ‘cmpval’ may be used uninitialized in this function [-Wmaybe-uninitialized]
> if (cmpval == 0 && lower1 != lower2)

So, apparently your compiler doesn't recognize that the loop always
has to execute at least once, because we don't support a table
partitioned on zero attributes. If you initialize cmpval to 0 at the
top of the function, does that fix it?

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Stephen Frost 2016-12-08 19:11:22 Re: [COMMITTERS] pgsql: Implement table partitioning.
Previous Message Stephen Frost 2016-12-08 18:49:31 Re: [COMMITTERS] pgsql: Implement table partitioning.

Browse pgsql-hackers by date

  From Date Subject
Next Message Stephen Frost 2016-12-08 19:11:22 Re: [COMMITTERS] pgsql: Implement table partitioning.
Previous Message Stephen Frost 2016-12-08 18:49:31 Re: [COMMITTERS] pgsql: Implement table partitioning.