Re: pg_walinspect: ReadNextXLogRecord's first_record argument

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>
Cc: Jeff Davis <pgsql(at)j-davis(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: pg_walinspect: ReadNextXLogRecord's first_record argument
Date: 2022-08-17 15:22:32
Message-ID: CA+Tgmob3FC+ot6vpunEeAQiq51fFe6XPEHKi57=KBDYxL-WCEw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Aug 17, 2022 at 12:41 AM Bharath Rupireddy
<bharath(dot)rupireddyforpostgres(at)gmail(dot)com> wrote:
> Agreed.
>
> Here's a patch (for V15 as well) fixing this bug, please review.

Couldn't you simplify this further by removing the lsn argument from
GetWALRecordInfo and using record->ReadRecPtr instead? Then
InitXLogReaderState's second argument could be XLogRecPtr instead of
XLogRecPtr *.

--
Robert Haas
EDB: http://www.enterprisedb.com

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Bharath Rupireddy 2022-08-17 16:28:56 Re: pg_walinspect: ReadNextXLogRecord's first_record argument
Previous Message Robert Haas 2022-08-17 15:14:24 Re: Generalize ereport_startup_progress infrastructure