| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Dagfinn Ilmari Mannsåker <ilmari(at)ilmari(dot)org> |
| Cc: | Shubham Khanna <khannashubham1197(at)gmail(dot)com>, pgsql-hackers(at)postgresql(dot)org, Andres Freund <andres(at)anarazel(dot)de> |
| Subject: | Re: Assorted typo fixes |
| Date: | 2024-01-02 17:34:20 |
| Message-ID: | CA+Tgmob-0ybwZPMb=AEckTP9wna8Em-nPVW_VXPdqNOLwJs6dQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Jan 1, 2024 at 6:05 PM Dagfinn Ilmari Mannsåker
<ilmari(at)ilmari(dot)org> wrote:
> Thanks. I've fixed the commit message (and elaborated it a bit more why
> I think it's a valid and safe fix).
Regarding 0001:
- AIUI, check_decls.m4 is copied from an upstream project, so I don't
think we should tinker with it.
- I'm not convinced by encrypter->encryptor
- I'm not convinced by multidimension-aware->multidimensional-aware
- I'm not convinced by cachable->cacheable
- You corrected restorting to restarting, but I'm wondering if Andres
intended restoring?
Committed the rest of 0001.
0002-0005 look OK to me, so I committed those as well.
With regard to 0006, we typically use indexes rather than indices as
the plural of "index", although exceptions exist.
I haven't looked at the rest.
--
Robert Haas
EDB: http://www.enterprisedb.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Melanie Plageman | 2024-01-02 17:36:18 | Re: Confine vacuum skip logic to lazy_scan_skip |
| Previous Message | Kumar, Sachin | 2024-01-02 17:33:00 | Re: pg_upgrade failing for 200+ million Large Objects |