Re: [PATCH] Use $ parameters as replacement characters for pg_stat_statements

On Wed, Mar 1, 2017 at 8:21 PM, Peter Eisentraut
<peter(dot)eisentraut(at)2ndquadrant(dot)com> wrote:
> On 2/28/17 20:01, Lukas Fittl wrote:
>> Currently pg_stat_statements replaces constant values with ? characters.
>> I've seen this be a problem on multiple occasions, in particular since
>> it conflicts with the use of ? as an operator.
>>
>> I'd like to propose changing the replacement character from ? to instead
>> be a parameter (like $1).
>
> Hmm, I think this could confuse people into thinking that the queries
> displayed were in fact prepared queries.
>
> Maybe we could gather some more ideas.

Perhaps there could be a choice of behaviors. Even if we all agreed
that parameter notation was better in theory, there's something to be
said for maintaining backward compatibility, or having an option to do
so.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company