| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Dilip Kumar <dilipbalaut(at)gmail(dot)com> |
| Cc: | Andres Freund <andres(at)anarazel(dot)de>, Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Make relfile tombstone files conditional on WAL level |
| Date: | 2022-03-07 19:54:07 |
| Message-ID: | CA+Tgmob=VXyY2KKW0q3=ut2s7KTiOnfZDCKVpWQ=kSk2=VTx+w@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Feb 21, 2022 at 2:51 AM Dilip Kumar <dilipbalaut(at)gmail(dot)com> wrote:
> While working on this I realized that even if we make the relfilenode
> 56 bits we can not remove the loop inside GetNewRelFileNode() for
> checking the file existence. Because it is always possible that the
> file reaches to the disk even before the WAL for advancing the next
> relfilenode and if the system crashes in between that then we might
> generate the duplicate relfilenode right?
I agree.
> I think the second paragraph in XLogPutNextOid() function explain this
> issue and now even after we get the wider relfilenode we will have
> this issue. Correct?
I think you are correct.
--
Robert Haas
EDB: http://www.enterprisedb.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2022-03-07 19:57:44 | Re: Make relfile tombstone files conditional on WAL level |
| Previous Message | Robert Haas | 2022-03-07 19:46:56 | Re: role self-revocation |