| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | "Rader, David" <davidr(at)openscg(dot)com> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [BUGS] Seems bug in postgres_fdw? |
| Date: | 2017-03-04 05:52:09 |
| Message-ID: | CA+Tgmob+VYjraqoaOa505OR=NON9tW5Gk8iXN2rMcb2hcBrF5Q@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs pgsql-hackers |
On Thu, Mar 2, 2017 at 3:28 AM, Rader, David <davidr(at)openscg(dot)com> wrote:
> Attached is a doc patch that updates the documentation for postgres-fdw to
> include the actual values for the 4 session variables that are set. Does
> that make sense to clarify?
From my point of view, this would be a sensible thing to document,
although I feel like the grammar is not quite right, because after
"establishes remote session settings for the parameters" my brain
expects a list of parameters rather than a list of parameters and the
corresponding values. I think it reads better if you change "for the
parameters" to "for various parameters".
</nitpicking>
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | manju.shedabal | 2017-03-04 10:21:28 | BUG #14577: error:ppas-9.5 service already exists on your system |
| Previous Message | Michael Meskes | 2017-03-03 19:11:32 | Re: [HACKERS] Two phase commit in ECPG |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2017-03-04 06:08:58 | Re: pg_dump, pg_dumpall and data durability |
| Previous Message | Robert Haas | 2017-03-04 05:46:50 | Re: Logical replication existing data copy |