Re: some grammar refactoring

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>
Cc: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: some grammar refactoring
Date: 2020-05-19 12:52:07
Message-ID: CA+Tgmoat8A2asWk3FygnvS9fdTPw7L-NybWG6toU80c3Mtb9ig@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, May 19, 2020 at 2:43 AM Peter Eisentraut
<peter(dot)eisentraut(at)2ndquadrant(dot)com> wrote:
> Here is a series of patches to do some refactoring in the grammar around
> the commands COMMENT, DROP, SECURITY LABEL, and ALTER EXTENSION ...
> ADD/DROP. In the grammar, these commands (with some exceptions)
> basically just take a reference to an object and later look it up in C
> code. Some of that was already generalized individually for each
> command (drop_type_any_name, drop_type_name, etc.). This patch combines
> it into common lists for all these commands.

I haven't reviewed the code, but +1 for the idea.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Konstantin Knizhnik 2020-05-19 13:07:29 Problem with pg_atomic_compare_exchange_u64 at 32-bit platformwd
Previous Message Robert Haas 2020-05-19 12:50:42 Re: Two fsync related performance issues?