Re: Proposal : Parallel Merge Join

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Dilip Kumar <dilipbalaut(at)gmail(dot)com>
Cc: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Proposal : Parallel Merge Join
Date: 2016-12-12 18:41:51
Message-ID: CA+Tgmoasn18bpuY-cMfiibpNX87F6ATvLjeCd87+sDs6as6q5Q@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Sat, Dec 10, 2016 at 7:59 AM, Dilip Kumar <dilipbalaut(at)gmail(dot)com> wrote:
> I would like to propose a patch for parallelizing merge join path.
> This idea is derived by analyzing TPCH results.
>
> I have done this analysis along with my colleagues Rafia sabih and Amit kaplia.
>
> Currently we already have infrastructure for executing parallel join,
> so we don't need any change at executor level. Only in path
> generation, we need to add partial paths for merge join, like we do
> for nest loop and hash join.

Hmm, so it seems my initial guess that we didn't need to bother
generating such paths was wrong. Oops.

This patch is hard to read because it is reorganizing a bunch of code
as well as adding new functionality. Perhaps you could separate it
into two patches, one with the refactoring and then the other with the
new functionality. Actually, though, I don't understand why you need
so much rearrangement....

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Petr Jelinek 2016-12-12 18:47:53 Re: pgsql: Add support for temporary replication slots
Previous Message Kevin Grittner 2016-12-12 18:32:47 Re: [OSSTEST PATCH 0/1] PostgreSQL db: Retry on constraint violation