| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr> |
| Cc: | "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: extensible options syntax for replication parser? |
| Date: | 2020-10-08 14:33:06 |
| Message-ID: | CA+TgmoasYGNVdgpQS4nE+T0AvE6pmLtK2GB3Ci07ey3cdA+uQQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Jun 24, 2020 at 11:51 AM Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
> Thanks for the review. v2 attached, hopefully fixing the compilation
> issue you mentioned.
Tushar Ahuja reported to me off-list that my basebackup refactoring
patch set was changing whether or not the following message appeared:
NOTICE: WAL archiving is not enabled; you must ensure that all
required WAL segments are copied through other means to complete the
backup
That patch set includes this patch, and the reason for the behavior
difference turned out to be that I had gotten an if-test that is part
of this patch backwards. Here is v3, fixing that. It is a little
disappointing that this mistake didn't cause any existing regression
tests to fail.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| Attachment | Content-Type | Size |
|---|---|---|
| v3-0001-Flexible-options-for-BASE_BACKUP-and-CREATE_REPLI.patch | application/octet-stream | 20.3 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bruce Momjian | 2020-10-08 16:23:10 | Re: Wrong example in the bloom documentation |
| Previous Message | Dilip Kumar | 2020-10-08 14:24:42 | Re: [HACKERS] Custom compression methods |