| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Andrew Dunstan <andrew(dot)dunstan(at)2ndquadrant(dot)com>, David Fetter <david(at)fetter(dot)org>, pgsql-committers <pgsql-committers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: pgsql: Add a non-strict version of jsonb_set |
| Date: | 2020-01-28 15:36:32 |
| Message-ID: | CA+Tgmoao4btGD_Cxqg7gRL1Xd1PKo8EKjaUaLvNiOy2Y5=meEQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
On Sun, Jan 19, 2020 at 7:19 PM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Ah, that makes sense. Although Mark's idea of including a library
> of possible hooks somewhere under src/tools/ seems even better.
+1. And directions for setting them up (or, as I think he was
proposing, a script, but directions might be better).
> Another point is that a server-side hook is really too late: you'd
> rather get the notice before you "git push", not after.
Yeah, getting warned at commit time would be good.
Another thing that would be nice is to warn about commits that don't
include a "Description:" line. I have been trying to be religious
about that, but I seem to periodically apostatize.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2020-01-28 15:37:00 | Re: pgsql: Add a non-strict version of jsonb_set |
| Previous Message | Tom Lane | 2020-01-28 15:05:36 | Re: pgsql: Remove dependency on HeapTuple from predicate locking functions. |