| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: pgsql: Removed unused variable, openLogOff. |
| Date: | 2019-03-07 13:03:19 |
| Message-ID: | CA+Tgmoaj-6K1yE0vgpOr60dVx0ES0+hQy6874tDi4bLkBKmbFg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
On Wed, Mar 6, 2019 at 6:53 PM Michael Paquier <michael(at)paquier(dot)xyz> wrote:
> On Wed, Mar 06, 2019 at 02:47:16PM +0000, Robert Haas wrote:
> > Removed unused variable, openLogOff.
>
> Is that right for the report if data is written in chunks? The same
> patch has been proposed a couple of weeks ago, and I commented about
> it as follows:
> https://www.postgresql.org/message-id/20190129043439.GB3121@paquier.xyz
Oh, sorry, I didn't see the earlier thread. You're right that this is
messed up: if we're going to report startOffset rather than
openLogOff, we need to report nleft rather than bytes. I would prefer
to change nbytes -> nleft rather than anything else, though, because
it seems to me that we should report the offset and length that
actually failed, not the start of the whole chunk which partially
succeeded.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alvaro Herrera | 2019-03-07 13:09:46 | pgsql: Add missing <limits.h> |
| Previous Message | Alvaro Herrera | 2019-03-07 12:35:48 | pgsql: pg_dump: allow multiple rows per insert |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Perumal Raj | 2019-03-07 13:39:49 | Resolved: Question about pg_upgrade from 9.2 to X.X |
| Previous Message | Filip Rembiałkowski | 2019-03-07 12:55:20 | Re: Ltree syntax improvement |