Re: buildfarm failures on crake and sittella

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Andrew Dunstan <andrew(at)dunslane(dot)net>
Cc: "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: buildfarm failures on crake and sittella
Date: 2015-10-17 22:19:54
Message-ID: CA+Tgmoaha6rJ_utO6z1E2sftuy=f5E7aFSnxdw9romjFE5eFDw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Sat, Oct 17, 2015 at 12:26 PM, Andrew Dunstan <andrew(at)dunslane(dot)net> wrote:
> I have done this and everything seems to be working. In the RedisFDW case,
> it does process certain quals (those in the form "key" = <constant>), but it
> has been doing the same thing in redisGetForeignPlan as filefdw does in
> fileGetForeignPlan, so I added the same fix i.e. passing back NIL as the
> extra parameter. I hope that's correct. If not, maybe we've been doing
> things a bit wrong for a while :-)

Thanks for getting to this so quickly. If you're processing the quals
remotely, but not remove them from the list of quals to be checked
locally by the executor, you're fine. If you are checking them
remotely *instead of* locally, then you need to make some changes that
should look similar to what the patch changed in postgres_fdw.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Noah Misch 2015-10-17 23:39:21 Re: a raft of parallelism-related bug fixes
Previous Message Robert Haas 2015-10-17 22:17:37 Re: a raft of parallelism-related bug fixes