| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
| Cc: | Ashutosh Bapat <ashutosh(dot)bapat(at)enterprisedb(dot)com>, Suraj Kharage <suraj(dot)kharage(at)enterprisedb(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: statement_timeout is not working as expected with postgres_fdw |
| Date: | 2017-05-07 15:54:48 |
| Message-ID: | CA+TgmoaesVGQpzBqts-eu1ZJmSaOE-kQgTFBCfMZ1PdymskDVg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Sun, May 7, 2017 at 12:42 AM, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
> On Sat, May 6, 2017 at 10:41 PM, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
>> On Sat, May 6, 2017 at 12:55 PM, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
>>> Oh! Good catch. Given that the behavior in question is intentional
>>> there and intended to provide backward compatibility, changing it in
>>> back-branches doesn't seem like a good plan. I'll adjust the patch so
>>> that it continues to ignore errors in that case.
>>
>> Updated patch attached.
>
> Patch looks good to me.
I'm having second thoughts based on some more experimentation I did
this morning. I'll update again once I've had a bit more time to poke
at it.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Mat Arye | 2017-05-07 17:04:12 | Question about toasting code |
| Previous Message | zosrothko | 2017-05-07 13:52:56 | Re: [Proposal]: Extends VisualStudio to automatically precompile EmbeddedSQL |