From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
---|---|
To: | Stephen Frost <sfrost(at)snowman(dot)net> |
Cc: | Don Seiler <don(at)seiler(dot)us>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
Subject: | Re: [PATCH] Include application_name in "connection authorized" log message |
Date: | 2018-06-22 15:02:00 |
Message-ID: | CA+TgmoaeHYvbOsHKFZJONzbgodU7deR=E+sAm=pooHTMRshn-g@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Wed, Jun 20, 2018 at 3:45 PM, Stephen Frost <sfrost(at)snowman(dot)net> wrote:
> * Don Seiler (don(at)seiler(dot)us) wrote:
>> In trying to troubleshoot the source of a recent connection storm, I was
>> frustrated to find that the app name was not included in the connection
>> messages. It is there in the log_line_prefix on the disconnection messages
>> but I would prefer it be directly visible with the connection itself. With
>> some guidance from Stephen Frost I've put together this patch which does
>> that.
>
> Yeah, I tend to agree that it'd be extremely useful to have this
> included in the 'connection authorized' message.
I don't get it. It seems like a bad idea to me to copy information
that can already be logged using log_line_prefix into the message
itself. If we start doing that, we'll end up with duplicated
information all over the place, and even worse, it won't be
consistent, because different people will want different things
duplicated into different messages.
Am I missing something?
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
From | Date | Subject | |
---|---|---|---|
Next Message | Robert Haas | 2018-06-22 15:06:10 | Re: New function pg_stat_statements_reset_query() to reset statistics of a specific query |
Previous Message | Robert Haas | 2018-06-22 14:58:28 | Re: Expression errors with "FOR UPDATE" and postgres_fdw with partition wise join enabled. |