| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Craig Ringer <craig(at)2ndquadrant(dot)com> |
| Cc: | Moon Insung <Moon_Insung_i3(at)lab(dot)ntt(dot)co(dot)jp>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>, Julien Rouhaud <rjuju123(at)gmail(dot)com>, Pavan Deolasee <pavan(dot)deolasee(at)2ndquadrant(dot)com>, Álvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, abhijit Menon-Sen <ams(at)2ndquadrant(dot)com>, Peter Geoghegan <pg(at)bowt(dot)ie>, Ashutosh Sharma <ashu(dot)coek88(at)gmail(dot)com> |
| Subject: | Re: [PATCH] pageinspect function to decode infomasks |
| Date: | 2017-08-15 13:24:28 |
| Message-ID: | CA+TgmoacQ+E9OFVQRJ2Pso=y2HgEE7W5u0oDSa3wyNmgKmQ1DA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Aug 14, 2017 at 9:59 PM, Craig Ringer <craig(at)2ndquadrant(dot)com> wrote:
> The bits are set, those macros just test to exclude the special meaning of
> both bits being set at once to mean "frozen".
>
> I was reluctant to filter out HEAP_XMIN_COMMITTED and HEAP_XMIN_INVALID
> when we detect that it's frozen, because that could well be misleading when
> debugging.
I don't think so -- the "committed" and "invalid" meanings are
effectively canceled when the "frozen" mask is present.
I mean, "committed" and "invalid" contradict each other...
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2017-08-15 13:32:30 | Re: Orphaned files in base/[oid] |
| Previous Message | Robert Haas | 2017-08-15 13:20:41 | Re: [BUGS] [postgresql 10 beta3] unrecognized node type: 90 |