Re: pg_size_pretty, SHOW, and spaces

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Bruce Momjian <bruce(at)momjian(dot)us>
Cc: Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, Christoph Berg <myon(at)debian(dot)org>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Greg Stark <stark(at)mit(dot)edu>, "David G(dot) Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com>, thomas(dot)berger(at)1und1(dot)de, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: pg_size_pretty, SHOW, and spaces
Date: 2016-08-05 18:07:18
Message-ID: CA+TgmoabmRseF-G33KhW3YCiWOXK8o2qpvUx7X=0bMyOib0Byw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs pgsql-hackers

On Fri, Aug 5, 2016 at 11:06 AM, Bruce Momjian <bruce(at)momjian(dot)us> wrote:
> On Fri, Aug 5, 2016 at 10:57:35AM -0400, Peter Eisentraut wrote:
>> On 8/2/16 12:51 PM, Bruce Momjian wrote:
>> > Yes, that's a strong argument for using a space. I have adjusted the
>> > patch to use spaces in all reasonable places. Patch attached, which I
>> > have gzipped because it was 133 KB. (Ah, see what I did there?) :-)
>> >
>> > I am thinking of leaving the 9.6 docs alone as I have already made them
>> > consistent (no space) with minimal changes. We can make it consistent
>> > the other way in PG 10.
>>
>> I don't think anyone wanted to *remove* the spaces in the documentation.
>> I think this change makes the documentation harder to read.
>
> Well, we had spaces in only a few places in the docs, and as I said, it
> is not consistent. Do you want those few put back for 9.6?

+1 for that. I can't see how it's good for 10 to be one way, 9.6 to
be the opposite way, and 9.5 and prior to be someplace in the middle.
That seems like a back-patching mess.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message Bruce Momjian 2016-08-05 18:41:48 Re: pg_size_pretty, SHOW, and spaces
Previous Message Tom Lane 2016-08-05 15:46:20 Re: BUG #14280: Error in PostgreSQL - could not extend file "base...": File too large

Browse pgsql-hackers by date

  From Date Subject
Next Message Andres Freund 2016-08-05 18:07:23 Re: truncate trigger for foreign data wrappers
Previous Message Robert Haas 2016-08-05 18:05:02 Re: truncate trigger for foreign data wrappers