| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com> |
| Cc: | Stephen Frost <sfrost(at)snowman(dot)net>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: needless complexity in StartupXLOG |
| Date: | 2021-07-27 15:03:14 |
| Message-ID: | CA+Tgmoaam26WcXhd5qtDaZGm0bb_U_zqwis_hyx9X3MDpLJawg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Jul 27, 2021 at 9:18 AM Kyotaro Horiguchi
<horikyota(dot)ntt(at)gmail(dot)com> wrote:
> FWIW, by the way, I complained that the variable name "promoted" is a
> bit confusing. It's old name was fast_promoted, which means that fast
> promotion is being *requsted* and ongoing. On the other hand the
> current name "promoted" still means "(fast=non-fallback) promotion is
> ongoing" so there was a conversation as the follows.
>
> https://www.postgresql.org/message-id/9fdd994d-a531-a52b-7906-e1cc22701310%40oss.nttdata.com
I agree - that variable name is also not great. I am open to making
improvements in that area and in others that have been suggested on
this thread, but my immediate goal is to figure out whether anyone
objects to me committing the posted patch. If nobody comes up with a
reason why it's a bad idea in the next few days, I'll plan to move
ahead with it.
--
Robert Haas
EDB: http://www.enterprisedb.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Mark Dilger | 2021-07-27 15:15:24 | Documentation disagrees with behavior of ALTER EVENT TRIGGER |
| Previous Message | Alvaro Herrera | 2021-07-27 15:01:03 | Re: Reduce the number of special cases to build contrib modules on windows |