Re: [COMMITTERS] pgsql: Code cleanup in the wake of recent LWLock refactoring.

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>
Cc: Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [COMMITTERS] pgsql: Code cleanup in the wake of recent LWLock refactoring.
Date: 2016-02-12 13:10:46
Message-ID: CA+TgmoaYug+Pm1DMPV_rY-w-nb8nhGjerz_L8wiHZtjiVhP+GQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

On Fri, Feb 12, 2016 at 3:33 AM, Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com> wrote:
>> There will be necessary more changes than this. Orafce has some parts
>> based on lw locks. I am able to compile it without any issue. But the lock
>> mechanism is broken now - so impact on extensions will be higher. Have to do
>> some research.
>
> if somebody would to use it for testing
>
> https://github.com/orafce/orafce
> https://github.com/orafce/orafce/commit/fff56ed7e17ed5d6f8e6b71591ff1a6d6ff12d79
>
> With last commit I am able to compile orafce without warnings, but
> installcheck is broken. It can be bug in orafce, but this code worked last 7
> years.

That's very strange. It looks to me like you did exactly the right
thing. Can you provide any details on how it fails?

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Pavel Stehule 2016-02-12 13:16:07 Re: [COMMITTERS] pgsql: Code cleanup in the wake of recent LWLock refactoring.
Previous Message Robert Haas 2016-02-12 13:07:33 pgsql: Make builtin lwlock tranche names consistent.

Browse pgsql-hackers by date

  From Date Subject
Next Message Pavel Stehule 2016-02-12 13:16:07 Re: [COMMITTERS] pgsql: Code cleanup in the wake of recent LWLock refactoring.
Previous Message Robert Haas 2016-02-12 13:07:47 Re: [PATCH] Refactoring of LWLock tranches