Re: RFC: replace pg_stat_activity.waiting with something more descriptive

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>
Cc: Alexander Korotkov <aekorotkov(at)gmail(dot)com>, "andres(at)anarazel(dot)de" <andres(at)anarazel(dot)de>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Vladimir Borodin <root(at)simply(dot)name>, Ildus Kurbangaliev <i(dot)kurbangaliev(at)postgrespro(dot)ru>, Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: RFC: replace pg_stat_activity.waiting with something more descriptive
Date: 2016-03-09 13:47:09
Message-ID: CA+TgmoaXxVDSOfsCDGtwvZKsL7rvmEVWcw0W_OH94xPqh_hdbw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Mar 9, 2016 at 8:31 AM, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
> Thanks for the suggestion. I have updated the patch to include wait_event_type information in the wait_event table.

I think we should remove "a server process is" from all of these entries.

Also, I think this kind of thing should be tightened up:

+ <entry>A server process is waiting on any one of the commit_timestamp
+ buffer locks to read or write the commit_timestamp page in the
+ pg_commit_ts subdirectory.</entry>

I'd just write: Waiting to read or write a commit timestamp buffer.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Masahiko Sawada 2016-03-09 14:09:46 Re: Freeze avoidance of very large table.
Previous Message Petr Jelinek 2016-03-09 13:41:07 Re: VS 2015 support in src/tools/msvc