| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp> |
| Cc: | Amit Langote <amitlangote09(at)gmail(dot)com>, Dmitry Ivanov <d(dot)ivanov(at)postgrespro(dot)ru>, Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Erik Rijkers <er(at)xs4all(dot)nl>, Rajkumar Raghuwanshi <rajkumar(dot)raghuwanshi(at)enterprisedb(dot)com>, Ashutosh Bapat <ashutosh(dot)bapat(at)enterprisedb(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>, pgsql-hackers-owner(at)postgresql(dot)org |
| Subject: | Re: Declarative partitioning - another take |
| Date: | 2016-12-20 16:53:55 |
| Message-ID: | CA+TgmoaXiCBTCQsUSpQJP9JsXHt7kj7m+oS+tQLKMChHCX7zpQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Dec 19, 2016 at 10:59 PM, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
> On Sun, Dec 18, 2016 at 10:00 PM, Amit Langote
> <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp> wrote:
>> Here are updated patches including the additional information.
>
> Thanks. Committed 0001. Will have to review the others when I'm less tired.
0002. Can you add a test case for the bug fixed by this patch?
0003. Loses equalTupleDescs() check and various cases where
ExecOpenIndexes can be skipped. Isn't that bad? Also, "We locked all
the partitions above including the leaf partitions" should say "Caller
must have locked all the partitions including the leaf partitions".
0004. Unnecessary whitespace change in executor.h. Still don't
understand why we need to hoist RelationGetPartitionQual() into the
caller.
0005. Can you add a test case for the bug fixed by this patch?
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2016-12-20 16:58:44 | Re: Protect syscache from bloating with negative cache entries |
| Previous Message | Ants Aasma | 2016-12-20 16:52:20 | Replication slot xmin is not reset if HS feedback is turned off while standby is shut down |