Re: pg_dump emits ALTER TABLE ONLY partitioned_table

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Stephen Frost <sfrost(at)snowman(dot)net>
Cc: Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Noah Misch <noah(at)leadboat(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: pg_dump emits ALTER TABLE ONLY partitioned_table
Date: 2017-04-25 17:15:52
Message-ID: CA+TgmoaW=qi4gfos=Bkc2t==58GruUrjja13A8LCqYsVawFYrg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Apr 25, 2017 at 12:26 PM, Stephen Frost <sfrost(at)snowman(dot)net> wrote:
> Interesting. Seems like the question is really what we mean by "ONLY"
> here. For my 2c, at least, if we can check that all of the partitions
> already have the constraint enforced, such that the only thing we're
> changing is the partitioned table, then that's exactly what "ONLY"
> should do. That would require a bit of rework, presumably, of how that
> keyword is handled but the basics are all there.

Well, I'm not saying that couldn't be done, but it doesn't add any
capability that we don't have today, so from my point of view it seems
fairly pointless. However, we can leave that for another day; for
now, I think we should focus on fixing the pg_dump bugs that this
thread is about.

> I'm planning to push just this patch to make the backend accept the
> ALTER TABLE ONLY when no partitions exist later this afternoon, ...

Cool.

> but the
> work here isn't done as noted in my other email.

Right. I'd just like to get the work done as soon as we reasonably
can. Tempus fugit, and all that.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Fabien COELHO 2017-04-25 17:19:40 Re: pgbench tap tests & minor fixes
Previous Message Bruce Momjian 2017-04-25 17:11:32 Re: PG 10 release notes