Re: [COMMITTERS] pgsql: New SQL functons pg_backup_in_progress() and pg_backup_start_tim

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Magnus Hagander <magnus(at)hagander(dot)net>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: [COMMITTERS] pgsql: New SQL functons pg_backup_in_progress() and pg_backup_start_tim
Date: 2012-06-15 12:16:59
Message-ID: CA+TgmoaULrZB4E3A0ezvtV9kJb9ki4p5OQJFc5hc-tsTB5tZuQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

On Fri, Jun 15, 2012 at 1:52 AM, Magnus Hagander <magnus(at)hagander(dot)net> wrote:
> On Fri, Jun 15, 2012 at 1:29 AM, Robert Haas <rhaas(at)postgresql(dot)org> wrote:
>> New SQL functons pg_backup_in_progress() and pg_backup_start_time()
>>
>> Darold Gilles, reviewed by Gabriele Bartolini and others, rebased by
>> Marco Nenciarini.  Stylistic cleanup and OID fixes by me.
>
> How well is the term "on-line exclusive backup" really settled with
> people? I wonder if we need to add a specific note to the docs saying
> that the function doesn't consider streaming base backups at all, and
> that one should refer to pg_stat_replication for info about those? Or
> really, should the function be pg_exclusive_backup_in_progress()
> perhaps?

Well, if we think that the term "exclusive backup" is not going to be
easily comprehensible, then sticking that into the function name isn't
going to help us much. I think that's just wordiness for the sake of
being wordy. I do agree that we could probably improve the clarity of
the documentation along the lines you suggest.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Magnus Hagander 2012-06-15 14:54:16 Re: [COMMITTERS] pgsql: New SQL functons pg_backup_in_progress() and pg_backup_start_tim
Previous Message Magnus Hagander 2012-06-15 05:52:36 Re: pgsql: New SQL functons pg_backup_in_progress() and pg_backup_start_tim

Browse pgsql-hackers by date

  From Date Subject
Next Message Merlin Moncure 2012-06-15 12:18:34 Re: libpq compression
Previous Message Robert Haas 2012-06-15 12:13:04 Re: [PATCH] Lazy hashaggregate when no aggregation is needed