Re: Re: fix cost subqueryscan wrong parallel cost

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: "bucoo(at)sohu(dot)com" <bucoo(at)sohu(dot)com>
Cc: Richard Guo <guofenglinux(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Re: fix cost subqueryscan wrong parallel cost
Date: 2022-04-21 12:00:30
Message-ID: CA+TgmoaTu8pEQDkjmOZAbbmsObYr=fHo1nHWXFga2R5BTQKoKw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Apr 21, 2022 at 2:38 AM bucoo(at)sohu(dot)com <bucoo(at)sohu(dot)com> wrote:
> > Suppose parallelism is not in use and that param_info is NULL. Then,
> > is path->subpath->rows guaranteed to be equal to baserel->rows? If
> > yes, then we don't need to a three-part if statement as you propose
> > here and can just change the "else" clause to say path->path.rows =
> > path->subpath->rows. If no, then your change gives the wrong answer.
>
> I checked some regress test, Sometimes subquery scan have filter,
> so path->subpath->row guaranteed *not* to be equal to baserel->rows.
> If the first patch is false, I don't known how to fix this,
> looks like need someone's help.

Please fix your mailer so that it doesn't send me a bounce message
every time I reply to one of your messages on list.

I don't know how to fix this right now either, then; maybe I or
someone else will have a good idea later.

--
Robert Haas
EDB: http://www.enterprisedb.com

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Eisentraut 2022-04-21 12:15:41 Re: Add version and data directory to initdb output
Previous Message Tomas Vondra 2022-04-21 11:48:16 Re: Assert failure in CTE inlining with view and correlated subquery