| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Dave Cramer <davecramer(at)postgres(dot)rocks> |
| Cc: | "Haumacher, Bernhard" <haui(at)haumacher(dot)de>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Error on failed COMMIT |
| Date: | 2020-02-14 18:29:19 |
| Message-ID: | CA+TgmoaSJ_oGvMjDZqzp2mQHtdzRoywqYpOp+UTHq7tu9so9NA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Feb 14, 2020 at 1:04 PM Dave Cramer <davecramer(at)postgres(dot)rocks> wrote:
> Thing is that con.commit() DOESN'T return a status code, nor does it throw an exception as we silently ROLLBACK here.
Why not? There's nothing keeping the driver from doing either of those
things, is there? I mean, if using libpq, you can use PQcmdStatus() to
get the command tag, and find out whether it's COMMIT or ROLLBACK. If
you're implementing the wire protocol directly, you can do something
similar.
https://www.postgresql.org/docs/current/libpq-exec.html#LIBPQ-EXEC-NONSELECT
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2020-02-14 18:34:03 | Re: [HACKERS] Moving relation extension locks out of heavyweight lock manager |
| Previous Message | Andres Freund | 2020-02-14 18:07:34 | Re: [HACKERS] Moving relation extension locks out of heavyweight lock manager |