| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Tristan Partin <tristan(at)neon(dot)tech>, John Naylor <johncnaylorls(at)gmail(dot)com>, Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>, Jelte Fennema-Nio <postgres(at)jeltef(dot)nl>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Add BF member koel-like indentation checks to SanityCheck CI |
| Date: | 2024-01-09 22:15:10 |
| Message-ID: | CA+TgmoaRJAkLZCfPhZZdrFs-taoXc=Xi+J0ZLWucuYCN5oTuKg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Jan 9, 2024 at 4:42 PM Daniel Gustafsson <daniel(at)yesql(dot)se> wrote:
> > On 9 Jan 2024, at 22:20, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> > In short, I don't think that putting this into CI is the answer.
> > Putting it into committers' standard workflow is a better idea,
> > if we can get all the committers on board with that.
>
> +many
I think we need to do that, too, but the question is how. The best
suggestion I've heard so far was to make it part of the build, or part
of the test suite, so that if you don't do it, some part of what you
were going to do anyway actually fails. That avoids making it an extra
step that you have to remember separately. We have an absolutely
insane number of things-you-must-always-remember-to-do.
--
Robert Haas
EDB: http://www.enterprisedb.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Jeremy Schneider | 2024-01-09 22:17:44 | Re: Built-in CTYPE provider |
| Previous Message | Jim Nasby | 2024-01-09 21:50:14 | Re: Add BF member koel-like indentation checks to SanityCheck CI |