| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | tushar <tushar(dot)ahuja(at)enterprisedb(dot)com> |
| Cc: | Dipesh Pandit <dipesh(dot)pandit(at)gmail(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>, Jeevan Ladhe <jeevan(dot)ladhe(at)enterprisedb(dot)com>, Dmitry Dolgov <9erthalion6(at)gmail(dot)com>, Mark Dilger <mark(dot)dilger(at)enterprisedb(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: refactoring basebackup.c |
| Date: | 2022-01-26 20:45:18 |
| Message-ID: | CA+TgmoaMwgdx8HxBjF8hmbohVvPL_0H5LqNrSq0uU+7BKp_Q2A@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Jan 25, 2022 at 11:22 AM tushar <tushar(dot)ahuja(at)enterprisedb(dot)com> wrote:
> A)Getting syntax error if -z is used along with -t
>
> [edb(at)centos7tushar bin]$ ./pg_basebackup -t server:/tmp/data902 -z -Xfetch
> pg_basebackup: error: could not initiate base backup: ERROR: syntax error
Oops. The attached patch should fix this.
> B)No information of "client-gzip" or "server-gzip" added under
> "--compress" option/method of ./pg_basebackup --help.
Already fixed by e1f860f13459e186479319aa9f65ef184277805f.
> C) -R option is silently ignoring
The attached patch should fix this, too.
Thanks for finding these issues.
--
Robert Haas
EDB: http://www.enterprisedb.com
| Attachment | Content-Type | Size |
|---|---|---|
| fix-mistakes-found-by-tushar.patch | application/octet-stream | 906 bytes |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2022-01-26 21:17:19 | snapper and skink and fairywren (oh my!) |
| Previous Message | Daniel Gustafsson | 2022-01-26 20:39:16 | Re: Support for NSS as a libpq TLS backend |