| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Amit Khandekar <amitdkhan(dot)pg(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: pgsql: Avoid coercing a whole-row variable that is already coerced |
| Date: | 2017-10-13 17:11:28 |
| Message-ID: | CA+TgmoaL8MJ0UkxfEBK0_sCWsv2J_omYbmbtUEQgVhiWBOGMYg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Oct 13, 2017 at 12:56 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> It's better ... but after reading the patched code, a lot of my remaining
> beef is with the lack of clarity of the comments. You need ESP to
> understand what the function is trying to accomplish and what the
> constraints are. I'll take a whack at improving that and push.
OK, thanks. The good thing is, now that we know you have ESP, you
can use it with the Ouija board Andres used to decide whether to apply
sizeof to the variable or the type. That's got to be a win.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Joshua D. Drake | 2017-10-13 17:13:34 | Re: Determine state of cluster (HA) |
| Previous Message | Robert Haas | 2017-10-13 17:06:41 | Re: Improve catcache/syscache performance. |