| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Andres Freund <andres(at)anarazel(dot)de> |
| Cc: | "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
| Subject: | Re: Why are we PageInit'ing buffers in RelationAddExtraBlocks()? |
| Date: | 2018-12-19 23:04:26 |
| Message-ID: | CA+TgmoaJ67VCefuhkd0fdJiWb64bqBtkbZazbVm6a0wimY0fRQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Dec 19, 2018 at 5:37 PM Andres Freund <andres(at)anarazel(dot)de> wrote:
> What's gained by the logic of emitting that warning in VACUUM after a
> crash? I don't really see any robustness advantages in it. If the logic
> were that we'd never reuse empty pages because they can hide corruption
> that normally would discovered by checksums, then we shouldn't
> reinitialize them at all and instead error out hard - but we can't do
> that, because it's normal that they occur. Right now we have empty
> pages on-disk whenever a busy server is restarted in immediate mode,
> after all.
I don't know. I am just normally reluctant to change things
precipitously that are of long tenure.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2018-12-19 23:14:37 | Re: slow queries over information schema.tables |
| Previous Message | Chengchao Yu | 2018-12-19 22:51:17 | RE: [PATCH] Fix Proposal - Deadlock Issue in Single User Mode When IO Failure Occurs |