Re: refactoring basebackup.c

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: tushar <tushar(dot)ahuja(at)enterprisedb(dot)com>
Cc: Jeevan Ladhe <jeevan(dot)ladhe(at)enterprisedb(dot)com>, Dmitry Dolgov <9erthalion6(at)gmail(dot)com>, Mark Dilger <mark(dot)dilger(at)enterprisedb(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: refactoring basebackup.c
Date: 2022-01-05 15:05:21
Message-ID: CA+TgmoaJ=VW8gxOMDtYB9rchiHo6V9AMrSWzT+RnWuc7xOezow@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Jan 5, 2022 at 5:11 AM tushar <tushar(dot)ahuja(at)enterprisedb(dot)com> wrote:
> One scenario where I feel error message is confusing and if it is not
> supported at all then error message need to be a little bit more clear
>
> if we use -z (or -Z ) with -t , we are getting this error
> [edb(at)centos7tushar bin]$ ./pg_basebackup -t server:/tmp/test0 -Xfetch -z
> pg_basebackup: error: only tar mode backups can be compressed
> Try "pg_basebackup --help" for more information.
>
> but after removing -z option backup is in tar mode only
>
> edb(at)centos7tushar bin]$ ./pg_basebackup -t server:/tmp/test0 -Xfetch
> [edb(at)centos7tushar bin]$ ls /tmp/test0
> backup_manifest base.tar

OK, fair enough, I can adjust the error message for that case.

--
Robert Haas
EDB: http://www.enterprisedb.com

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2022-01-05 15:13:16 Re: Refactoring of compression options in pg_basebackup
Previous Message Simon Riggs 2022-01-05 14:45:56 Re: Pluggable toaster