Re: pg_waldump's inclusion of backend headers is a mess

On Tue, Feb 14, 2017 at 2:54 PM, Andres Freund <andres(at)anarazel(dot)de> wrote:
>> Thoughts, comments, objections, better ideas?
>
> No better ideas. I'm a bit concerned about declarations needed both by
> normal and xlog related routines, but I guess that can be solved by a
> third header as you did.

Yeah, that doesn't seem bad to me. I think it's actually fairly
unfortunate that we've just shoved declarations from 3 or 4 or 5
different source files into a single header in many of these cases. I
think it leads to not thinking clearly about what the dependencies
between the different source files in the index AM stuff is, and
certainly there seems to be some room for improvement there,
especially with regard to gist and gin. Sorting that out is a bigger
project than I'm prepared to undertake right now, but I think this is
probably a step in the right direction.

>> +++ b/src/include/access/nbtxlog.h
>> @@ -0,0 +1,255 @@
>> +/*-------------------------------------------------------------------------
>> + *
>> + * nbtree.h
>> + * header file for postgres btree xlog routines
>
> Wrong file name.

Thanks to you and Michael for the reviews. Committed.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company