Re: [HACKERS] parallel.c oblivion of worker-startup failures

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>
Cc: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [HACKERS] parallel.c oblivion of worker-startup failures
Date: 2017-12-11 17:57:43
Message-ID: CA+TgmoaEzMODByVrXAxqPQ3732DoSCzy+kiOZUYhTTG=BzYkrQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Sun, Dec 10, 2017 at 11:07 PM, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
> Okay, see the attached and let me know if that suffices the need?

+ * Check for unexpected worker death. This will ensure that if
+ * the postmaster failed to start the worker, then we don't wait
+ * for it indefinitely. For workers that are known to be
+ * launched, we can rely on their error queue being freed once
+ * they exit.

Hmm. Is this really true? What if the worker starts up but then
crashes before attaching to the error queue?

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tomas Vondra 2017-12-11 17:59:32 Re: Rethinking MemoryContext creation
Previous Message Jeremy Finzel 2017-12-11 17:55:22 Testing Extension Upgrade Paths