| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Amul Sul <sulamul(at)gmail(dot)com> |
| Cc: | Michael Paquier <michael(at)paquier(dot)xyz>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Add system identifier to backup manifest |
| Date: | 2024-03-07 14:16:47 |
| Message-ID: | CA+TgmoaEw8owxVD86atn05vxgd_5G6SX9iq1uCCZFO0+VGjgLA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Mar 6, 2024 at 11:22 PM Amul Sul <sulamul(at)gmail(dot)com> wrote:
>> You are not changing silently the internals of get_controlfile(), so
>> no objections here. The name of the new routine could be shorter, but
>> being short of ideas what you are proposing looks fine by me.
>
> Could be get_controlfile_by_path() ?
It could. I just thought this was clearer. I agree that it's a bit
long, but I don't think this is worth bikeshedding very much. If at a
later time somebody feels strongly that it needs to be changed, so be
it. Right now, getting on with the business at hand is more important,
IMHO.
--
Robert Haas
EDB: http://www.enterprisedb.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Langote | 2024-03-07 14:23:56 | Re: remaining sql/json patches |
| Previous Message | Alvaro Herrera | 2024-03-07 14:14:15 | Re: remaining sql/json patches |