Re: A couple logical decoding fixes/patches

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Andres Freund <andres(at)2ndquadrant(dot)com>
Cc: "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: A couple logical decoding fixes/patches
Date: 2014-05-09 14:49:09
Message-ID: CA+TgmoaEmr6U+QNzZQKO_YjYpkJ4DHHchyhctJYWerqSFp8ksg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, May 8, 2014 at 12:29 PM, Andres Freund <andres(at)2ndquadrant(dot)com> wrote:
> Patch 01: Fix a couple of embarassing typos. Most of them harmless, but
> one isn't and can lead to crashing or decoding wrong data.

Committed.

> Patch 02: Don't crash with an Assert() failure if wal_level=logical but
> max_replication_slots=0.

Committed.

> Patch 03: Add valgrind suppression for writing out padding bytes. That's
> better than zeroing the data from the get go because unitialized
> accesses are still detected.

I have no understanding of valgrind suppressions. I can commit this
blindly if nobody else wants to pick it up.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Andres Freund 2014-05-09 14:53:18 Re: 9.4 release notes
Previous Message Andres Freund 2014-05-09 14:32:01 Re: default opclass for jsonb (was Re: Call for GIST/GIN/SP-GIST opclass documentation)