| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Christoph Berg <myon(at)debian(dot)org>, Andres Freund <andres(at)anarazel(dot)de>, pgsql-committers <pgsql-committers(at)postgresql(dot)org> |
| Subject: | Re: pgsql: Provide overflow safe integer math inline functions. |
| Date: | 2017-12-13 14:37:25 |
| Message-ID: | CA+TgmoaBj4vDrbGK15mf-nvQ6N=fD7SBJSFr0Vi6Edoy0x2E3g@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
On Wed, Dec 13, 2017 at 5:10 AM, Christoph Berg <myon(at)debian(dot)org> wrote:
> Re: Andres Freund 2017-12-13 <E1eOvQF-00075r-Cy(at)gemulon(dot)postgresql(dot)org>
>> Provide overflow safe integer math inline functions.
>
> The new _overflow functions have buggy comments:
>
> /*
> * If a - b overflows, return true, otherwise store the result of a + b into
> * *result. ^ there
What's wrong with that?
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Eisentraut | 2017-12-13 15:39:39 | pgsql: Fix crash when using CALL on an aggregate |
| Previous Message | Christoph Berg | 2017-12-13 10:10:37 | Re: pgsql: Provide overflow safe integer math inline functions. |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Stephen Frost | 2017-12-13 15:04:57 | Re: PATCH: Exclude unlogged tables from base backups |
| Previous Message | Dmitry Dolgov | 2017-12-13 13:46:14 | Re: [HACKERS] eval_const_expresisions and ScalarArrayOpExpr |