Re: Use PG_MODULE_MAGIC_EXT macro in modules added in PG19

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Michael Paquier <michael(at)paquier(dot)xyz>
Cc: Andreas Karlsson <andreas(at)proxel(dot)se>, "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Use PG_MODULE_MAGIC_EXT macro in modules added in PG19
Date: 2026-07-02 23:45:12
Message-ID: CA+TgmoaBgHRtoZNaeuij5S17aBGL7giR41fh44Xz1paO5gcRNQ@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Jul 2, 2026 at 7:42 PM Michael Paquier <michael(at)paquier(dot)xyz> wrote:
> On Thu, Jul 02, 2026 at 11:55:55PM +0200, Andreas Karlsson wrote:
> > It looks like we forgot about the PG_MODULE_MAGIC_EXT macro when adding
> > pg_plan_advice, pg_stash_advice and pgrepack so here is a patch fixing that.
> >
> > Maybe we should also use the new macro in other places like our test modules
> > and our modules in the documentation and the tutorial but there I am less
> > certain and that is a separate topic.
>
> It would be sad to see all that missing the release train, as the SQL
> function to see loaded libraries is super useful. Will probably take
> care of it in a few days, except if their respective committers show
> up in-between.

We've got a long holiday weekend coming up here so I'm not going to be
spending too much time at the keyboard the next few days, but I'm
happy to have you take care of this if you feel like doing that. If
you feel like I should take care of it, then I can do that next week.

--
Robert Haas
EDB: http://www.enterprisedb.com

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Xuneng Zhou 2026-07-02 23:50:38 Re: BUG: ReadStream look-ahead exhausts local buffers when effective_io_concurrency>=64
Previous Message Michael Paquier 2026-07-02 23:42:09 Re: Use PG_MODULE_MAGIC_EXT macro in modules added in PG19