Re: Question about StartLogicalReplication() error path

On Mon, Jun 14, 2021 at 12:50 PM Jeff Davis <pgsql(at)j-davis(dot)com> wrote:
> It seems that there's not much agreement in a behavior change here. I
> suggest one or more of the following:
>
> 1. change the logical rep protocol docs to match the current behavior
> a. also briefly explain in the docs why it's different from
> physical replication (which does always start at the provided LSN as
> far as I can tell)
>
> 2. Change the comment to add something like "Starting at a different
> LSN than requested might not catch certain kinds of client errors.
> Clients should be careful to check confirmed_flush_lsn if starting at
> the requested LSN is required."
>
> 3. upgrade DEBUG1 message to a WARNING
>
> Can I get agreement on any of the above suggestions?

I'm happy to hear other opinions, but I think I would be inclined to
vote in favor of #1 and/or #2 but against #3.

--
Robert Haas
EDB: http://www.enterprisedb.com