Re: Drop --disable-floatN-byval configure options?

On Wed, Feb 21, 2018 at 10:50 AM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Per the discussion at
> https://www.postgresql.org/message-id/flat/54dfd2022c205eda9aa35b88923f027a%40postgrespro.ru
> it's become evident that use of --disable-float8-byval breaks at least one
> current regression test case, because it results in a large change in hash
> table size for float8 hash keys. While we could hack around that somehow,
> I think it would be a poor use of development effort. I have a modest
> substitute proposal: let's just drop the --disable-float4-byval and
> --disable-float8-byval configure options as of v11. Those don't have any
> impact on on-disk storage.

USE_FLOAT4_BYVAL seems completely pointless to me, but don't we need
USE_FLOAT8_BYVAL on machines where Datum is only 4 bytes wide? If
we've got to support that case on such machines, I'm not sure I'm in
favor of removing the option to have that behavior on other machines.
Being able to test such things without digging up a 32-bit machine is
useful.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company