On Tue, Aug 9, 2022 at 11:16 AM Zhihong Yu <zyu(at)yugabyte(dot)com> wrote:
> tupDesc is declared inside `if (!node->sort_Done)` block whereas the last reference to tupDesc is outside the if block.
Yep.
> I take your review comment and will go back to do more homework.
The real point for me here is you haven't offered any reason to make
this change. The structure member in question is basically free.
Because of alignment padding it uses no more memory, and it makes the
intent of the code clearer.
Let's not change things just because we could.
--
Robert Haas
EDB: http://www.enterprisedb.com