| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Andres Freund <andres(at)anarazel(dot)de>, Ashwin Agrawal <aagrawal(at)pivotal(dot)io>, PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Create TOAST table only if AM needs |
| Date: | 2019-05-17 20:47:34 |
| Message-ID: | CA+Tgmoa4O2n=yphqD2pERUnYmUO84bH1SqMsA-nSxBGsZ7gWfA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, May 17, 2019 at 3:26 PM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> It seems to me that the entire tableam project is still very much WIP,
> and if anybody is able to do anything actually useful with a different
> AM right at the moment, that's just mighty good fortune for them.
> It's way too late to be making destabilizing changes in v12 in order
> to move the frontier of what can be done in a new AM.
What about non-destabilizing changes? It seems to me that we could do
some good with a pretty simple patch that just moves most of the logic
from needs_toast_table() below tableam, as in the attached. Then we
could leave the broader refactoring for v13.
Maybe this is still too much, but it seems pretty simple so I thought I'd ask.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-tableam-Move-heap-specific-logic-from-needs_toast_ta.patch | application/octet-stream | 7.0 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2019-05-17 20:51:54 | Re: Create TOAST table only if AM needs |
| Previous Message | Tom Lane | 2019-05-17 20:36:12 | Re: hyrax vs. RelationBuildPartitionDesc |