Re: Multiple TO version in ALTER EXTENSION UPDATE

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Daniel Gustafsson <daniel(at)yesql(dot)se>
Cc: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Multiple TO version in ALTER EXTENSION UPDATE
Date: 2017-06-22 14:48:25
Message-ID: CA+Tgmoa4Byi-vw_Qa4T+2Eb7RdkVfBdauX4-fv-wEx6DLEC2Ug@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Mar 29, 2017 at 11:13 AM, Daniel Gustafsson <daniel(at)yesql(dot)se> wrote:
> While reading I noticed that we allow multiple TO <version> in ALTER EXTENSION
> UPDATE, and defer throwing a syntax error until command processing. Is there a
> reason for deferring and not handling it in gram.y directly as in the attached
> patch since it is in fact a syntax error? It yields a different error message
> to the user, but makes for easier to read code (IMH-and-biased-O).

I think the idea of the current implementation was probably that the
grammar should leave room to support multiple options in arbitrary
order at that point in the syntax. I'm not sure whether that's
something we'll ever actually need, or not.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2017-06-22 14:54:52 Re: Prologue of set_append_rel_size() and partitioned tables
Previous Message Robert Haas 2017-06-22 14:38:41 Re: Re-indent HEAD tomorrow?