Re: Suggestion: Issue warning when calling SET TRANSACTION outside transaction block

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Bruce Momjian <bruce(at)momjian(dot)us>
Cc: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Andres Freund <andres(at)2ndquadrant(dot)com>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Morten Hustveit <morten(at)eventures(dot)vc>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Suggestion: Issue warning when calling SET TRANSACTION outside transaction block
Date: 2013-11-28 21:51:14
Message-ID: CA+Tgmoa3qLBgM3UAxskNCqOJge=EPmZ2T0jee4ZCPHzHZLRjXw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Nov 27, 2013 at 4:44 PM, Bruce Momjian <bruce(at)momjian(dot)us> wrote:
>> Seems broadly reasonable, but I'd use "no other effect" throughout.
>
> That sounds awkward, e.g.:
>
> Issuing <command>ROLLBACK</> outside of a transaction
> block emits a warning but has no other effect.
>
> I could live with this:
>
> Issuing <command>ROLLBACK</> outside of a transaction
> block has no effect except emitting a warning.

I prefer the first version, but that's obviously a judgement call.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2013-11-28 22:00:05 Re: new unicode table border styles for psql
Previous Message Alvaro Herrera 2013-11-28 21:48:54 Re: new unicode table border styles for psql