Re: pg_*_advice: tsv load failure, etc.

On Thu, Sep 10, 2026 at 4:10 PM Ayush Tiwari
<ayushtiwari(dot)slg01(at)gmail(dot)com> wrote:
> I applied v5 and spent some time looking at 0002. ISTM there may still be
> one nearby case that isn't handled:
>
> JOIN_ORDER((a b))
> JOIN_ORDER({a b})
>
> AFAICS, both forms are enforced correctly, but the feedback says
> "partially matched".

Oh, crap, you're right. I actually noticed that and then set it aside
because it was in a different area of the code than I was fixing, and
then I forget to come back to it. Oops. I'll have to add another patch
to cover that case.

> > 0003 Disallow empty sublists within JOIN_ORDER(). New in this version
> > of the patch set. Trivial fix for a gap in parse-time validation of
> > advice strings.
>
> 0003 looks good to me.

Thanks.

--
Robert Haas
EDB: http://www.enterprisedb.com