| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | GetTupleForTrigger could use a header comment |
| Date: | 2017-11-16 17:48:55 |
| Message-ID: | CA+Tgmoa1z+53RAvT573G4+dS0o5Q5pRPP0P64G3z9sYYyX4igg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
GetTupleForTrigger seems to be a fairly important part of the trigger
machinery, yet it has no header comment. I think it should, although
I don't understand it well enough at this point to write one. Right
now, one is left to guess at the overall purpose of the function and
the meanings of the arguments. For example, it does something very
different based on whether newSlot != NULL, with zero explanation as
to the underlying reasons or theory of operation. Whee!
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2017-11-16 17:57:49 | Re: [HACKERS] Inconsistencies between pg_settings and postgresql.conf |
| Previous Message | Fabrízio de Royes Mello | 2017-11-16 17:45:58 | Re: pgsql: Disable installcheck tests for test_session_hooks |