Re: Re: [COMMITTERS] pgsql: Add trigonometric functions that work in degrees.

On Fri, Apr 8, 2016 at 5:48 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Peter Eisentraut <peter_e(at)gmx(dot)net> writes:
>> On 01/22/2016 03:46 PM, Tom Lane wrote:
>>> Add trigonometric functions that work in degrees.
>
>> I have a host here that is having regression test failures from this commit:
>
>> --- src/test/regress/expected/float8.out
>> +++ src/test/regress/results/float8.out
>> @@ -490,9 +490,9 @@
>> x | asind | acosd | atand
>> ------+-------+-------+-------
>> -1 | -90 | 180 | -45
>> - -0.5 | -30 | 120 |
>> + -0.5 | | 120 |
>> 0 | 0 | 90 | 0
>> - 0.5 | 30 | 60 |
>> + 0.5 | | 60 |
>> 1 | 90 | 0 | 45
>> (5 rows)
>
> BTW ... looking closer at that, it appears to show asind(-0.5) and
> asind(0.5) returning NULL. Which makes no sense at all, because
> there is no provision in dasind() for returning a null, regardless
> of the input value.
>
> So I'm pretty baffled. Maybe you could step through this and figure
> out where it's going off the rails?

Peter, are you going to look into this further? This is on the open
items list, but there seems to be nothing that can be done about it by
anyone other than, maybe, you.

If you're not going to look into it, I think we should delete the open
item. There's no point in tracking issues that aren't actionable.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company