Re: [PATCH] fix AddRelsyncInvalidationMessage

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Stolpovskikh Danil <d(dot)stolpovskikh(at)ftdata(dot)ru>
Cc: "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>, Bykov Ivan <i(dot)bykov(at)ftdata(dot)ru>, Lozhkov Alexander <A(dot)Lozhkov(at)ftdata(dot)ru>
Subject: Re: [PATCH] fix AddRelsyncInvalidationMessage
Date: 2026-06-11 21:18:43
Message-ID: CA+Tgmoa1HXnAEWqkwuTX32R-SmO+yxZDL1Pez7+qE7fXgQ=ksw@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Jun 11, 2026 at 7:44 AM Stolpovskikh Danil
<d(dot)stolpovskikh(at)ftdata(dot)ru> wrote:
> I found a small problem in the AddRelsyncInvalidationMessage function of the inval.c module.
>
> A year ago, a patch was added that added a new type of message (SHAREDINVALRELSYNC_ID) and filling in messages of this type was not done correctly, the wrong field was used(msg.rc instead msg.rs).

I think you're correct, but a similar mistake also occurs just a few
lines earlier. I have pushed 99db753c656 to fix both things.

--
Robert Haas
EDB: http://www.enterprisedb.com

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Matheus Alcantara 2026-06-11 21:31:07 Re: LLVM JIT: any JIT-compiled query crashes (SIGILL) on a libLLVM 19 + ASAN build
Previous Message Tomas Vondra 2026-06-11 21:02:56 Re: Key joins