| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Thomas Munro <thomas(dot)munro(at)gmail(dot)com> |
| Cc: | Michael Paquier <michael(at)paquier(dot)xyz>, Dilip Kumar <dilipbalaut(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Kevin Grittner <kgrittn(at)gmail(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: fixing old_snapshot_threshold's time->xid mapping |
| Date: | 2020-09-24 19:46:14 |
| Message-ID: | CA+Tgmoa0sy72ccFK8WRFAv_5U1gsCwnQuhNhKYcC+CYqNuCdpw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Sep 23, 2020 at 9:16 PM Thomas Munro <thomas(dot)munro(at)gmail(dot)com> wrote:
> LGTM.
Committed.
Thomas, with respect to your part of this patch set, I wonder if we
can make the functions that you're using to write tests safe enough
that we could add them to contrib/old_snapshot and let users run them
if they want. As you have them, they are hedged around with vague and
scary warnings, but is that really justified? And if so, can it be
fixed? It would be nicer not to end up with two loadable modules here,
and maybe the right sorts of functions could even have some practical
use.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Konstantin Knizhnik | 2020-09-24 20:10:19 | Re: Custom options for building extensions with --with--llvm |
| Previous Message | Daniel Gustafsson | 2020-09-24 19:44:57 | Re: scram-sha-256 broken with FIPS and OpenSSL 1.0.2 |