From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | pgsql-hackers(at)postgresql(dot)org |
Subject: | Re: Getting rid of pre-assignment of index names in CREATE TABLE LIKE |
Date: | 2012-07-16 17:40:13 |
Message-ID: | CA+Tgmoa-bZmTG_Oi56NjzSQ1CW3z7m96PfFtzmP2CRRo1900+g@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Mon, Jul 16, 2012 at 1:10 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Robert Haas <robertmhaas(at)gmail(dot)com> writes:
>> The problem isn't confined to CREATE TABLE LIKE; it's a widespread
>> design flaw that will likely take years of work to clean up
>> completely. I don't think that's a reason not to commit your change
>> though; it fixes a bug and is an incremental improvement, even if a
>> small one. That having been said, if you're feeling an urge to tackle
>> the problem more broadly, don't let me stand in your way...
>
> Not me; I'm just trying to close out a bug report.
>
> FWIW, I think your argument only barely supports this change at all,
> because CREATE TABLE LIKE is still generating an IndexStmt which after
> all is the representation of a CREATE INDEX command. We've overloaded
> it to do a few other things, and now it will be able to do one more
> thing, but this isn't moving things at all towards separating high-
> and low-level operations.
:-(
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
From | Date | Subject | |
---|---|---|---|
Next Message | Mike Wilson | 2012-07-16 17:58:11 | Re: BUG #6733: All Tables Empty After pg_upgrade (PG 9.2.0 beta 2) |
Previous Message | Robert Haas | 2012-07-16 17:39:46 | Re: CompactCheckpointerRequestQueue versus pad bytes |