| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Dilip Kumar <dilipbalaut(at)gmail(dot)com> |
| Cc: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: pgsql: Document XLOG_INCLUDE_XID a little better |
| Date: | 2021-10-04 17:13:20 |
| Message-ID: | CA+Tgmoa-V9fKXj-gr24-D-v=sck4r5Re4by8knu004Fc9h4qug@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
On Sat, Oct 2, 2021 at 6:46 AM Dilip Kumar <dilipbalaut(at)gmail(dot)com> wrote:
> I have written two patches, Approach1 is as you described using a
> static boolean and Approach2 as a local variable to XLogAssembleRecord
> as described by Amit, attached both of them for your reference.
> IMHO, either of these approaches looks cleaner.
I agree, and I don't have a strong preference between them. If I were
writing code like this from scratch, I would do what 0001 does. But
0002 is arguably more consistent with the existing style. It's kind of
hard to judge, at least for me, which is to be preferred.
--
Robert Haas
EDB: http://www.enterprisedb.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2021-10-04 17:34:47 | pgsql: Doc: fix minor issues in GiST support function documentation. |
| Previous Message | Daniel Gustafsson | 2021-10-04 13:14:18 | pgsql: Fix duplicate words in comments |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Daniel Gustafsson | 2021-10-04 17:21:25 | Re: [PATCH] Print error when libpq-refs-stamp fails |
| Previous Message | Sergey Shinderuk | 2021-10-04 17:09:28 | Bug in DefineRange() with multiranges |