| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Ashutosh Bapat <ashutosh(dot)bapat(at)enterprisedb(dot)com> |
| Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Use get_greatest_modulus() in partition_bounds_equal() |
| Date: | 2017-12-01 18:55:48 |
| Message-ID: | CA+Tgmoa-Dc1C-1qrR3e8T8eMu9R1OwRjhNZAq9MwDJAzyjDKMQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Dec 1, 2017 at 5:13 AM, Ashutosh Bapat
<ashutosh(dot)bapat(at)enterprisedb(dot)com> wrote:
> partition_bounds_equal() accesses the last datum from the given
> partition bounds directly to compare their greatest moduli. Rest of
> the code uses get_greatest_modulus() to get the greatest modulus from
> a partition bound. partition_bounds_equal() should also do the same
> for the sake of consistency and to make sure the in future the code
> remains sane if we change the way we store greatest modulus in
> PartitionBoundInfoData in future.
Makes sense. Committed.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2017-12-01 19:02:59 | Re: [HACKERS] pow support for pgbench |
| Previous Message | Bossart, Nathan | 2017-12-01 18:53:03 | Re: BUG #14941: Vacuum crashes |