| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Noah Misch <noah(at)leadboat(dot)com> |
| Cc: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, Fujii Masao <masao(dot)fujii(at)gmail(dot)com>, Petr Jelinek <petr(dot)jelinek(at)2ndquadrant(dot)com>, Kyotaro HORIGUCHI <horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: some review comments on logical rep code |
| Date: | 2017-05-01 11:51:59 |
| Message-ID: | CA+Tgmoa=_DFbi_6izms=-Kpj0n71VRXPLpR06R7HZ=RT=i3ZBg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Sat, Apr 29, 2017 at 12:33 AM, Noah Misch <noah(at)leadboat(dot)com> wrote:
>> I think the patch that Fujii Masao has proposed has found general
>> agreement. I would recommend that he commits it as he sees fit.
>
> This is not a conforming status update, because it does not specify a date for
> your next update.
If Peter thinks that the issues fixed by this patch don't really need
to be corrected, then we could interpret this as a statement that it
should not be listed as an open item but that he does not object to
someone else fixing it anyway.
If these are real issues, then Peter should take responsibility for
them because they were created by his commit. If Fujii Masao is
willing to help by committing the patch in question, great; but if
not, then Peter should be responsible for committing.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Kapila | 2017-05-01 11:58:39 | Re: [PROPOSAL] Use SnapshotAny in get_actual_variable_range |
| Previous Message | Amit Kapila | 2017-05-01 10:52:58 | Re: RFC: ALTER SYSTEM [...] COMMENT |